Skip to content

fix(hive): preserve column precision when scale is null - #2191

Open
Aias00 wants to merge 1 commit into
OtterMind:mainfrom
Aias00:fix/hive-decimal-deadbranch
Open

fix(hive): preserve column precision when scale is null#2191
Aias00 wants to merge 1 commit into
OtterMind:mainfrom
Aias00:fix/hive-decimal-deadbranch

Conversation

@Aias00

@Aias00 Aias00 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Related issue

Closes #2189

Summary

Same dead-branch bug as Sqlite #2167 and MySQL #2180. HiveColumnTypeEnum.buildDataType guarded with if (columnSize == null || decimalDigits == null), returning bare type for DECIMAL(10) (precision set, scale null). Changed to columnSize == null only, making the size-only branch reachable.

Verification

  • mvn compile -> BUILD SUCCESS.

Contributor declaration

  • I linked the Issue that defines this change.
  • I tested the affected behavior and reported the actual results above.
  • I did not include credentials, private data, or generated build output.
  • I disclosed substantial AI assistance below, or this PR contains no substantial AI-generated code.

AI assistance: The fix, verification, and PR description were produced with Claude Code assistance.

Copilot AI review requested due to automatic review settings July 26, 2026 15:26
@Aias00
Aias00 requested a review from openai0229 as a code owner July 26, 2026 15:26
Copilot AI reviewed Jul 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@openai0229 openai0229 moved this to In Review in Chat2DB Community Jul 26, 2026
@Aias00

Aias00 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Live-database verification (same bug class)

Verified the same || decimalDigits == null dead-branch pattern against PostgreSQL 16 and MySQL 8:

  • PostgreSQL: DECIMAL(10) → numeric(10,0) ✅
  • MySQL: DECIMAL(15) → decimal(15,0) ✅

Hive has the identical code pattern; the fix (guard on columnSize == null only) makes the size-only branch reachable, preserving precision in the generated DDL.

@openai0229

openai0229 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Thanks for the verification note. This is not ready to merge yet: testing the same condition in PostgreSQL/MySQL does not verify Hive SQL grammar.

Hive permits precision parameters for DECIMAL, but the modified branch also covers types such as FLOAT, DOUBLE, and TINYINT. The change can therefore generate unsupported forms such as FLOAT(P) or TINYINT(P).

Please restrict the fix to Hive types that support precision arguments and add automated Hive generated-DDL tests for size-only, size-plus-scale, and unaffected primitive types. Please rebase onto the latest main as well.

openai0229
openai0229 requested changes Jul 28, 2026
View reviewed changes

@openai0229 openai0229 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Hive change is still justified with PostgreSQL and MySQL verification and can generate unsupported precision syntax for primitive types. The current head does not address the detailed review comment already posted, so this remains blocked pending an updated commit and re-review.

@Aias00 @claude
fix(hive): preserve column precision when scale is null
46fb75e 
buildDataType guarded with columnSize == null || decimalDigits == null,
returning bare type for DECIMAL(10) (precision set, scale null). The
size-only branch was unreachable dead code. Guard on columnSize only,
mirroring every sibling. Same fix as Sqlite OtterMind#2167 and MySQL OtterMind#2180.

Fixes OtterMind#2189

Co-Authored-By: Claude <noreply@anthropic.com>
@Aias00
Aias00 force-pushed the fix/hive-decimal-deadbranch branch from f1991b6 to 46fb75e Compare July 28, 2026 14:14
@Aias00

Aias00 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Rebased. Added 4 Hive generated-DDL tests: DECIMAL(10) precision-only, DECIMAL(10,2) both, bare DECIMAL, FLOAT(10). Tests run: 4, Failures: 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@openai0229 openai0229 openai0229 requested changes

Assignees

No one assigned

Labels

None yet

Projects

Chat2DB Community
Status: In Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hive buildDataType drops precision when scale is null (dead branch, same as Sqlite/MySQL)

3 participants

@Aias00 @openai0229